Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new INFINIDAT (InfiniBox) storage backend to the Sunbeam storage subsystem, along with unit test coverage and fixture wiring to include it in the existing backend test matrix.
Changes:
- Implement
InfinidatBackendandInfinidatConfig(including protocol enum + secret-marked SAN credentials). - Add INFINIDAT-specific unit tests and config validation tests.
- Extend shared backend test fixtures and “unique backend type/charm name” assertions to include INFINIDAT.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/infinidat/backend.py | New INFINIDAT backend + Pydantic config model and charm metadata defaults. |
| sunbeam-python/sunbeam/storage/backends/infinidat/init.py | Introduces the INFINIDAT backend package. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_infinidat.py | Adds backend contract tests + protocol validation tests for INFINIDAT. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds an infinidat_backend fixture and includes it in the parametrized backend fixture. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Updates shared tests to include INFINIDAT in uniqueness and expectation matrices. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-infinidat-charm
branch
from
b578f3c to
72ecc99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983838